Iris icon indicating copy to clipboard operation
Iris copied to clipboard

End shader no longer working for custom dimension types

Open LCLPYT opened this issue 2 years ago • 0 comments

What happened?

I have a world on my server that uses a custom dimension type. The dimension type is added via a datapack and is configured so that is has the end sky enabled:

{
  "effects": "minecraft:the_end",
  // more properties ...
}

The end dimension shader was enabled by Iris just fine. Recently though, I upgraded Iris from 1.6.4 to 1.6.11. Since then, the overworld shader is enabled instead.

Screenshots

Before the upgrade (Iris 1.6.4): iris 1.6.4

After the upgrade (Iris 1.6.11): iris 1.6.11

Log output

latest.log

Minecraft Version

Minecraft 1.20.1

Iris Version

iris-mc1.20.1-1.6.11.jar

Operating System

Windows 10

What is your GPU?

Nvidia GeForce RTX 4070

Additional context

I modified the NBT data of the world I am using. This way the overworld of my server lobby can have a different dimension type, like so: image

Upon a little search, I found this commit which is likely the reason. It seems the hardcoded check for the end and nether effects were removed and replaced with a shader-specific dimension.properties file.

I tried modifying the file, but it seems the lookup is done only for the dimension of the world. Is there a way to configure dimension types instead?

Also, it seems very impractical to me, that I have to patch shader packs in order to get the proper shader for my world... Is there a better way?

LCLPYT avatar Dec 23 '23 18:12 LCLPYT