Iris icon indicating copy to clipboard operation
Iris copied to clipboard

Issue using the vanilla takePanorama() method

Open Fridtjof-DE opened this issue 2 years ago • 6 comments

What happened?

A made a small mod that makes the vanilla game's takePanorama() method usable. It works as intended but however as soon as I start using IrisShaders the six panorama screenshots just show the sky color. When testing I was using no shader pack. The method is located at net.minecraft.client.MinecraftClient.takePanorama() The mod

Screenshots

iris_panorama_issue

Log output

No response

Minecraft Version

Minecraft 1.20.4

Iris Version

iris-mc1.20.4-1.6.14.jar

Operating System

Windows 10 Home 19045.3803

What is your GPU?

Nvidia GeForce GTX 750Ti

Additional context

No response

Fridtjof-DE avatar Dec 21 '23 12:12 Fridtjof-DE

The vanilla method could need re-implementation to ensure that all the needed Iris state is properly set up. One complexity for high quality panoramas is that it is likely necessary to render multiple frames at each perspective to give time for things like temporal anti-aliasing to settle down and give a properly anti-aliased image. This is similar to the issues with Immersive Portals where AA can't settle down as easily in some cases since it's effectively the camera jumping back and forth very fast from the shader pack perspective.

coderbot16 avatar Dec 31 '23 21:12 coderbot16

The vanilla method could need re-implementation to ensure that all the needed Iris state is properly set up. One complexity for high quality panoramas is that it is likely necessary to render multiple frames at each perspective to give time for things like temporal anti-aliasing to settle down and give a properly anti-aliased image. This is similar to the issues with Immersive Portals where AA can't settle down as easily in some cases since it's effectively the camera jumping back and forth very fast from the shader pack perspective.

So... Fix in next update?

Gazmanovich avatar Mar 06 '24 16:03 Gazmanovich

Unlikely as the only current active developer of Iris is IMS212, and they are focused on other development work.

coderbot16 avatar Mar 06 '24 17:03 coderbot16

up. 1.20.1 also not working

AdamCalculator avatar Jun 21 '24 12:06 AdamCalculator

can confirm it's still present in 1.21 https://github.com/TerraformersMC/Vistas/issues/22

YkVox avatar Nov 28 '24 09:11 YkVox