easy-markdown-editor icon indicating copy to clipboard operation
easy-markdown-editor copied to clipboard

Published 20 hours ago • verified publisher icon Ionaru

Fix unused `iconClassMap` option

Open MrMicky-FR opened this issue 2 years ago • 1 comments

Currently the iconClassMap option has absolutely no effects, because the values of the built-in iconClassMap variable are directly inlined in the toolbarBuiltInButtons during script initialization which occurs before the constructor call where options are passed.

This PR changes this, by using options.iconClassMap during toolbar creation, which occurs in constructor call

MrMicky-FR avatar Oct 03 '22 08:10 MrMicky-FR

Hi @Ionaru, do you think you could look at this when you have some time ? Because currently the iconClassMap option isn’t working, and this PR fixes this issues and introduced no breaking changes, and the test are passing. Thanks a lot :)

MrMicky-FR avatar Feb 04 '23 21:02 MrMicky-FR