Proxyshop icon indicating copy to clipboard operation
Proxyshop copied to clipboard

Feature request: The ability to add flavor bar even for cards with no rules text (only flavor text)

Open HelixVita opened this issue 2 years ago • 1 comments

There are 63 cards in Magic's history which meet this criterion.

Here they are: https://scryfall.com/search?q=-o%3A%2F.%2F+%28s%3Apor+or+s%3Ap02+or+s%3Aptk+or+s%3As99%29+-t%3Abasic

Screenshots Intended appearance on left, Proxyshop render on right. image

HelixVita avatar Aug 27 '22 17:08 HelixVita

Scrolling thru all the cards on the scryfall search results page, it seems that they all have the divider in the exact same position.

image

This means that one could probably implement a slightly "hacky" but much faster way. Roughly speaking:

  1. Let norulesbounds be a new bounding box for rules text placement defined as the lower half of the normal bounding box
  2. If card has flavor text AND card has no rules text, use norulesbounds instead of the normal bounding box
  3. Unhide the flavor divider and place it always at the same x/y position (in the middle of the rules box)

HelixVita avatar Aug 27 '22 17:08 HelixVita

Yeah this seems outside the scope of Proxyshop's goals, I think something like this should be left to template makers, if I implement it at app level its not gonna turn out looking like the result you want anyways without some template level customizing lol

Should be fairly easy to define at the template level though! Create a new reference box for this case, and create a post-text-layers() method, check for this case, then use the resize function and the framing function to frame the text to that reference, and place your divider in the predefined position. EZ PZ

Investigamer avatar Nov 05 '22 17:11 Investigamer