BetterDiscordStuff
BetterDiscordStuff copied to clipboard
Inve1951
Update linkProfilePicture.plugin.js
Might you have missed line 16 which came with the original code ? The new BD update requires plugins to have a stop function, not the functionality. Satisfying a requirement without changing old code is always a preference.
Not including actual functionality within stop() makes the plugin make multiple hooks into the click action if you load/unload the plugin repeatedly, which will cause multiple copies of the link to get opened with a single click.
I don't notice such behavior after testing it. But I did also have to change it for it to work properly as stated in #184. I did also see Scribbles' deleted reply a moment ago. Anyways I'd still approve #184 after they fix that one bit I pointed out that recently changed. But square would still be the one to merge it or not so.
Yes, I had to actually get back into this, since I've seen broken code being shared as working and branded as better while it is itself broken as illustrated here #183
I can't believe making a pull request to solve an issue could blew up into all this for whatever reason. it's not like I'm saying the other suggested answer is bad, in fact it's much more clean and follows propre semantics, However i thought I'd share this little fix since it stray far from the original code and follows the original dev way of doin things.
Still doesn't work?
For now, just manually add an empty stop function inside the linkProfilePicture class like this:
module.exports = class linkProfilePicture { start() { ... } stop() {} }
module.exports = class linkProfilePicture { start() { ... } stop() {} }
Do i need to remove anything from line 12 or anything else?
Do i need to remove anything from line 12 or anything else?
Uhh just copy paste from this pastebin instead. https://pastebin.com/B6nUFvQ2
Do i need to remove anything from line 12 or anything else?
Uhh just copy paste from this pastebin instead. https://pastebin.com/B6nUFvQ2
It doesn't show any error at start but even if you click on the avatars it won't open bigger either.
Is the script actually enabled in the plugins section?
On Thu, Aug 18, 2022, 23:07 PrototypeGR @.***> wrote:
Do i need to remove anything from line 12 or anything else?
Uhh just copy paste from this pastebin instead. https://pastebin.com/B6nUFvQ2
It doesn't show any error at start but even if you click on the avatars it won't open bigger either.
— Reply to this email directly, view it on GitHub https://github.com/Inve1951/BetterDiscordStuff/pull/185#issuecomment-1219964190, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASTZ5T6EICNVABWH7EBXTJTVZ2QZVANCNFSM56AOYXQA . You are receiving this because you commented.Message ID: @.***>
Idk then it is interfering with a different plugin or something. It's working perfectly fine for me with the same copy pasted code.
On Thu, Aug 18, 2022, 23:13 PrototypeGR @.***> wrote:
Yes
— Reply to this email directly, view it on GitHub https://github.com/Inve1951/BetterDiscordStuff/pull/185#issuecomment-1219969428, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASTZ5T35DINO7C2BQXJNISTVZ2ROJANCNFSM56AOYXQA . You are receiving this because you commented.Message ID: @.***>
