SampleApp-CRUD-PHP icon indicating copy to clipboard operation
SampleApp-CRUD-PHP copied to clipboard

comments added for learning purposes.

Open tistudios opened this issue 6 years ago • 2 comments

added closing php tag

tistudios avatar Oct 29 '18 23:10 tistudios

Your request changes one of the quotation marks to an apostrophe, but not the ending mark. These should both be changed since interpolation is not occurring within that string. Additionally, a closing PHP tag isn't strictly necessary and there are various positive points supporting leaving the tag out within a PHP-only file.

wolveix avatar Jan 22 '19 13:01 wolveix

The first one was made in error. Thanks for catching that.

Re 2nd point, thanks for letting me know its considered poor practice. Maybe others could make the same mistake if they base it on assumption, I will add a comment with a link to some documentation. Thanks Wolveix.

tistudios avatar Jan 28 '19 05:01 tistudios