PySubstringSearch icon indicating copy to clipboard operation
PySubstringSearch copied to clipboard

multiple substring matches

Open Khanifsaleh opened this issue 2 years ago • 9 comments

does it support for search by multiple substring? like (?:substring1|substring2|substring1) in regex

Khanifsaleh avatar Apr 13 '22 07:04 Khanifsaleh

It does not, but this is definitely a good suggestion and I will implement it ASAP.

Thanks!

wavenator avatar Apr 13 '22 07:04 wavenator

Hi @wavenator , any update for it? :)

Khanifsaleh avatar Apr 20 '22 04:04 Khanifsaleh

done! have fun and thanks for using the library!

wavenator avatar Apr 20 '22 13:04 wavenator

@wavenator big proud of you,

but I think it will be perfect if user can set the AND/OR logical between the substrings. :)

Khanifsaleh avatar Apr 20 '22 14:04 Khanifsaleh

or num of substring occurances for each documents :)

Khanifsaleh avatar Apr 20 '22 17:04 Khanifsaleh

@wavenator big proud of you,

but I think it will be perfect if user can set the AND/OR logical between the substrings. :)

Your'e welcome!

This is a bit missing the point of using the suffix array data type here. I completely understand the use case but unfortunately I am not sure this library should implement this case. I'd be happy if you can elaborate more on the usage you vision so I can answer more accurately.

Thanks!

wavenator avatar Apr 20 '22 17:04 wavenator

@wavenator big proud of you, but I think it will be perfect if user can set the AND/OR logical between the substrings. :)

Your'e welcome!

This is a bit missing the point of using the suffix array data type here. I completely understand the use case but unfortunately I am not sure this library should implement this case. I'd be happy if you can elaborate more on the usage you vision so I can answer more accurately.

Thanks!

Oke. Really good project.

Khanifsaleh avatar Apr 20 '22 18:04 Khanifsaleh

or num of substring occurances for each documents :)

But I still hope you can make this feature, Or extract which substrings that contains in matched douments.

Khanifsaleh avatar Apr 20 '22 18:04 Khanifsaleh

or num of substring occurances for each documents :)

Hi @wavenator, are you working on this?

Khanifsaleh avatar Apr 25 '22 07:04 Khanifsaleh