Improve tests

[Bulga-xD]

trafficstars

This PR is regarding only improving the UnitTests(adding some parametrized tests). Keep in mind behavior and the number of the tests are the same. Just removing not needed noise in the code.

Directly reject it if doesn't look reasonable to you.

[Bulga-xD]

@JonasKs Please take a look here. This is so interesting for me :)

[JonasKs]

I will go through it all tomorrow😊 Thank you for the PR!!

[JonasKs]

I absolutely love this! If you do this out of the main branch (renaming the generate_obj function etc.) it would be awesome

[Bulga-xD]

@JonasKs Should you rebase it or do I have to create a brand new MR?

[JonasKs]

@kristiqntashev , you have to sync your main branch. See the GitHub documentation here.

You can then either rebase main into your improve_tests branch, or as you said, create a new branch from main. I'd rebase, but it can be a hassle if it is the first time. So do whatever you find easiest 😊

[JonasKs]

Awesome 😊

I think, in general, the test suite for this package is a bit too repetitive. Right now the b2c folder and multi-tenant folder is more or less the same (except for which class is used). I think we could definitely make this into just one folder, and remove a good chunk of tests.. If we're to add a B2CSingleTenantAuthorizationBearer, this don't really scale. One code change would break 4 sets of equal tests.

I'm going on vacation tonight, so I'll probably not be able to really give a review or merge for a week or two. But I'll try to get back to you ASAP when I'm back home 😊

[Bulga-xD]

I will do it next week quite busy this.

[JonasKs]

No rush, thank you so much for contributing 😊

[Bulga-xD]

Too much work I will finish this soon as possible.

[JonasKs]

No rush!😊

[JonasKs]

Closing for inactivity. Feel free to re-open.