fastapi-azure-auth
fastapi-azure-auth copied to clipboard
Trying a condition for pydantic v2 support.
in regards to https://github.com/Intility/fastapi-azure-auth/issues/150 I am getting warnings about the field_validator. I'm not sure if we want to have some future proofing around the validator warning. This change cleans up the warning I get from testing when using Pydantic v2
Codecov Report
Merging #169 (87150c0) into main (88e08fa) will decrease coverage by
1.6%. The diff coverage is63.6%.
@@ Coverage Diff @@
## main #169 +/- ##
========================================
- Coverage 100.0% 98.4% -1.6%
========================================
Files 6 6
Lines 247 253 +6
========================================
+ Hits 247 249 +2
- Misses 0 4 +4
| Files | Coverage Δ | |
|---|---|---|
| fastapi_azure_auth/user.py | 94.1% <63.6%> (-5.9%) |
:arrow_down: |
Thank you 😊 I think we can start dropping v1 support, so no need to keep v1 validators.
I will have more time mid November, and hope to have a pydantic v2-only release out in December.
Sorry for the long delay on this one.
I would like to:
- Remove all token v1 support
- Only support Pydantic v2 for new releases
This should increase the maintainability of this packge.
I thought I'd ask you whether you would like to help/review, or if I should go ahead myself. 😊
What's the current status? I would like to remove these deprecation warnings from my tests. Do you need any help?
Any PR with the removal of v1 support would be appreciated. 😊
Thanks so much, sorry it took a while to get rid of these. v5 will fix this, see #200