plutus icon indicating copy to clipboard operation
plutus copied to clipboard

Plutus context list to maps undocumented?

Open SebastienGllmt opened this issue 3 years ago • 2 comments

It seems that in the Plutus V2 context, some types were switched from lists to maps, but this isn't mentioned anywhere. What was the rationale for this change?

Plutus V2 context: https://github.com/input-output-hk/plutus/blob/65fa7ce05a810947f565ac59b4d4e35b3cd5d1b3/plutus-ledger-api/src/PlutusLedgerApi/V2/Contexts.hs#L87

Plutus V1 context: https://github.com/input-output-hk/plutus/blob/65fa7ce05a810947f565ac59b4d4e35b3cd5d1b3/plutus-ledger-api/src/PlutusLedgerApi/V1/Contexts.hs#L108

Seems this change was introduced without more context here: https://github.com/input-output-hk/plutus/pull/3952

SebastienGllmt avatar Jun 16 '22 20:06 SebastienGllmt

I don't remember the details, @SebastienGllmt . I'll move this issue to the Plutus repository.

JaredCorduan avatar Jun 17 '22 12:06 JaredCorduan

Map is more accurate, it was an oversight that they weren't before.

michaelpj avatar Jun 17 '22 12:06 michaelpj

but this isn't mentioned anywhere

We now have a changelog, so breaking changes like that should end up there. Otherwise there doesn't seem to be anything else that we could do here, so I'm closing. Feel free to reopen if you disagree.

effectfully avatar Jan 31 '23 22:01 effectfully