ouroboros-network icon indicating copy to clipboard operation
ouroboros-network copied to clipboard

Peer selection test failure: busyness property vaiolation

Open coot opened this issue 3 months ago • 0 comments

It fails in the main branch:

      no excess busyness:                                                       FAIL (825.58s)
        *** Failed! Falsified (after 77 tests and 355 shrinks):
        GovernorMockEnvironment {peerGraph = PeerGraph [(PeerAddr 2,[],GovernorScripts {peerShareScript = Script (Nothing :| []), peerSharingScript = Script (PeerSharingEnabled :| []), connectionScript = Script ((Noop,NoDelay) :| [])}),(PeerAddr 8,[],GovernorScripts {peerShareScript = Script (Nothing :| []), peerSharingScript = Script (PeerSharingDisabled :| [PeerSharingEnabled]), connectionScript = Script ((ToCooling,LongDelay) :| [(ToCooling,NoDelay),(ToCold,ShortDelay),(Noop,NoDelay)])}),(PeerAddr 9,[],GovernorScripts {peerShareScript = Script (Just ([],PeerShareTimeSlow) :| []), peerSharingScript = Script (PeerSharingEnabled :| []), connectionScript = Script ((Noop,NoDelay) :| [])}),(PeerAddr 11,[],GovernorScripts {peerShareScript = Script (Nothing :| [Just ([],PeerShareTimeSlow)]), peerSharingScript = Script (PeerSharingEnabled :| []), connectionScript = Script ((ToCold,ShortDelay) :| [(ToCold,NoDelay),(Noop,NoDelay)])}),(PeerAddr 22,[PeerAddr 2,PeerAddr 11,PeerAddr 25,PeerAddr 35],GovernorScripts {peerShareScript = Script (Just ([PeerAddr 25],PeerShareTimeQuick) :| [Nothing,Just ([PeerAddr 2,PeerAddr 11,PeerAddr 35],PeerShareTimeQuick)]), peerSharingScript = Script (PeerSharingEnabled :| []), connectionScript = Script ((Noop,NoDelay) :| [])}),(PeerAddr 23,[],GovernorScripts {peerShareScript = Script (Just ([],PeerShareTimeTimeout) :| [Nothing]), peerSharingScript = Script (PeerSharingEnabled :| []), connectionScript = Script ((Noop,NoDelay) :| [])}),(PeerAddr 25,[],GovernorScripts {peerShareScript = Script (Nothing :| [Nothing,Nothing,Nothing,Just ([],PeerShareTimeTimeout)]), peerSharingScript = Script (PeerSharingEnabled :| []), connectionScript = Script ((Noop,NoDelay) :| [])}),(PeerAddr 34,[PeerAddr 22],GovernorScripts {peerShareScript = Script (Nothing :| [Just ([PeerAddr 22],PeerShareTimeQuick)]), peerSharingScript = Script (PeerSharingEnabled :| []), connectionScript = Script ((Noop,NoDelay) :| [])}),(PeerAddr 35,[],GovernorScripts {peerShareScript = Script (Nothing :| [Nothing,Just ([],PeerShareTimeTimeout)]), peerSharingScript = Script (PeerSharingEnabled :| []), connectionScript = Script ((Noop,NoDelay) :| [])})], localRootPeers = fromGroups [(HotValency {getHotValency = 1},WarmValency {getWarmValency = 1},fromList [(PeerAddr 8,LocalRootConfig {peerAdvertise = DoAdvertisePeer, diffusionMode = InitiatorOnlyDiffusionMode, extraLocalRootFlags = IsNotTrustable})])], publicRootPeers = PublicRootPeers {getLedgerPeers = fromList [PeerAddr 9,PeerAddr 23,PeerAddr 34], getBigLedgerPeers = fromList [], getExtraPeers = ExtraPeers {publicConfigPeers = fromList [], bootstrapPeers = fromList []}}, targets = Script (((PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 1, targetNumberOfEstablishedPeers = 1, targetNumberOfActivePeers = 1, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0},PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 1, targetNumberOfEstablishedPeers = 1, targetNumberOfActivePeers = 1, targetNumberOfKnownBigLedgerPeers = 10, targetNumberOfEstablishedBigLedgerPeers = 1, targetNumberOfActiveBigLedgerPeers = 1}),NoDelay) :| [((PeerSelectionTargets {targetNumberOfRootPeers = 0, targetNumberOfKnownPeers = 1, targetNumberOfEstablishedPeers = 1, targetNumberOfActivePeers = 1, targetNumberOfKnownBigLedgerPeers = 0, targetNumberOfEstablishedBigLedgerPeers = 0, targetNumberOfActiveBigLedgerPeers = 0},PeerSelectionTargets {targetNumberOfRootPeers = 5, targetNumberOfKnownPeers = 10, targetNumberOfEstablishedPeers = 9, targetNumberOfActivePeers = 1, targetNumberOfKnownBigLedgerPeers = 10, targetNumberOfEstablishedBigLedgerPeers = 1, targetNumberOfActiveBigLedgerPeers = 1}),NoDelay)]), pickKnownPeersForPeerShare = Script (PickAll :| [PickFirst,PickFirst,PickAll,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickFirst,PickAll]), pickColdPeersToPromote = Script (PickFirst :| []), pickWarmPeersToPromote = Script (PickFirst :| []), pickHotPeersToDemote = Script (PickFirst :| []), pickWarmPeersToDemote = Script (PickFirst :| []), pickColdPeersToForget = Script (PickFirst :| []), pickInboundPeers = Script (PickFirst :| []), peerSharingFlag = PeerSharingEnabled, useBootstrapPeers = Script ((DontUseBootstrapPeers,NoDelay) :| []), consensusMode = GenesisMode, useLedgerPeers = Script ((UseLedgerPeers (After (SlotNo 929720740906613519)),NoDelay) :| []), ledgerStateJudgement = Script ((TooOld,NoDelay) :| [(TooOld,NoDelay)]), seed = TestSeed {unTestSeed = 4233786296863674790}}
        busy span too long
        start time:   Time 18915s
        end time:     Time 19001s
        span credits: 85s
        first 50 events:
        (Time 18915s,GovernorEvent TraceGovernorWakeup)
        (Time 18915s,GovernorAssociationMode Unrestricted)
        (Time 18915s,GovernorEvent (TracePeerShareRequests 10 9 (PeerSharingAmount {getAmount = 8}) (fromList [PeerAddr 2,PeerAddr 25]) (fromList [PeerAddr 2,PeerAddr 25])))
        (Time 18915s,MockEnvEvent (TraceEnvPeerShareRequest (PeerAddr 2) Nothing))
        (Time 18915s,GovernorAssociationMode Unrestricted)
        (Time 18915s,MockEnvEvent (TraceEnvPeerShareRequest (PeerAddr 25) (Just ([],PeerShareTimeTimeout))))
        (Time 18916s,MockEnvEvent (TraceEnvPeerShareResult (PeerAddr 2) []))
        (Time 18918s,GovernorEvent (TracePeerShareResults [(PeerAddr 2,Left user error (no peers))]))
        (Time 18918s,GovernorEvent (TracePeerShareResultsFiltered []))
        (Time 18918s,GovernorAssociationMode Unrestricted)
        (Time 18918s,GovernorEvent (TracePeerShareRequests 10 9 (PeerSharingAmount {getAmount = 8}) (fromList [PeerAddr 35]) (fromList [PeerAddr 35])))
        (Time 18918s,MockEnvEvent (TraceEnvPeerShareRequest (PeerAddr 35) (Just ([],PeerShareTimeTimeout))))
        (Time 18918s,GovernorAssociationMode Unrestricted)
        (Time 18921s,GovernorEvent (TracePeerShareResults []))
        (Time 18921s,GovernorEvent (TracePeerShareResultsFiltered []))
        (Time 18921s,GovernorAssociationMode Unrestricted)
        (Time 18925s,GovernorEvent (TracePeerShareResults [(PeerAddr 25,Left AsyncCancelled)]))
        (Time 18925s,GovernorEvent (TracePeerShareResultsFiltered []))
        (Time 18925s,GovernorAssociationMode Unrestricted)
        (Time 18928s,GovernorEvent (TracePeerShareResults [(PeerAddr 35,Left AsyncCancelled)]))
        (Time 18928s,GovernorEvent (TracePeerShareResultsFiltered []))
        (Time 18928s,GovernorAssociationMode Unrestricted)
        (Time 18973s,GovernorEvent TraceGovernorWakeup)
        (Time 18973s,GovernorAssociationMode Unrestricted)
        (Time 18973s,GovernorEvent (TracePeerShareRequests 10 9 (PeerSharingAmount {getAmount = 8}) (fromList [PeerAddr 8]) (fromList [PeerAddr 8])))
        (Time 18973s,MockEnvEvent (TraceEnvPeerShareRequest (PeerAddr 8) Nothing))
        (Time 18973s,GovernorAssociationMode Unrestricted)
        (Time 18974s,MockEnvEvent (TraceEnvPeerShareResult (PeerAddr 8) []))
        (Time 18974s,GovernorEvent (TracePeerShareResults [(PeerAddr 8,Left user error (no peers))]))
        (Time 18974s,GovernorEvent (TracePeerShareResultsFiltered []))
        (Time 18974s,GovernorAssociationMode Unrestricted)
        (Time 18998s,GovernorEvent TraceGovernorWakeup)
        (Time 18998s,GovernorAssociationMode Unrestricted)
        (Time 18998s,GovernorEvent (TracePeerShareRequests 10 9 (PeerSharingAmount {getAmount = 8}) (fromList [PeerAddr 11]) (fromList [PeerAddr 11])))
        (Time 18998s,MockEnvEvent (TraceEnvPeerShareRequest (PeerAddr 11) (Just ([],PeerShareTimeSlow))))
        (Time 18998s,GovernorAssociationMode Unrestricted)
        (Time 19001s,GovernorEvent (TracePeerShareResults []))
        (Time 19001s,GovernorEvent (TracePeerShareResultsFiltered []))
        (Time 19001s,GovernorAssociationMode Unrestricted)
        
        Use --quickcheck-replay="(SMGen 1150139416850274466 7237844500674993191,76)" to reproduce.
        Use -p '/no excess busyness/' to rerun this test only.

coot avatar Oct 07 '25 18:10 coot