Move to get Haskell packages from CHaP

[andreabedini]

This moves the repository to use cardano-haskell-packages (CHaP) repository.

This is currently blocked by https://github.com/input-output-hk/io-sim/pull/37. CHaP had been pre-populated with the dependencies of the lastest release of cardano-node, but ouroboros-network has progressed in the meantime requiring a newer version of io-sim which is not in CHaP yet.

[michaelpj]

This is currently blocked by https://github.com/input-output-hk/io-sim/pull/37.

It doesn't have to be blocked: use a s-r-p for now, and then we can remove it once that is merged. We can still get this PR in before that.

[michaelpj]

Note that shell.nix is using cabalWrapped, which can and should go.

[andreabedini]

It doesn't have to be blocked: use a s-r-p for now, and then we can remove it once that is merged. We can still get this PR in before that.

ok, I will chase this up on Monday.

[andreabedini]

Now at least it builds. Left to do is to remove one srp at the time so see if we can improve on the situation.

[michaelpj]

I think we could merge this as is and then work from this point? any objections?

[andreabedini]

I think we could merge this as is and then work from this point? any objections?

I am just trying to see if the new io-sim packages help.

[andreabedini]

But perhaps you made a good point that it can be done in a separate PR

[michaelpj]

I am just trying to see if the new io-sim packages help.

I just tried that and they don't work with the version of typed-protocols being used :sweat_smile: So I think let's move on for now.

[andreabedini]

Ok, let's call this done. We will improve on it later.

[michaelpj]

We just got compatible typed-protocols published, I'm just trying to see if I can roll that into this also.

[michaelpj]

Worked locally, pushing it.

[nfrisby]

By reading the new text in CONTRIBUTING.md, will I understand everything I need to understand in order to review the rest of this PR? Thanks!

cc @andreabedini @michaelpj

[michaelpj]

@nfrisby if you read it and you don't understand, then I regard that as a deficiency in the text and please say so :) you might also need to read the CHaP readme, which is linked.

[michaelpj]

@coot is this good to go?

[coot]

@michaelpj this is only about using CHaP, not releasing anything to it, right? The next version of packages from this repo needs to be released from the release/cardano-node.1.35.x branch not master.

[andreabedini]

this is only about using CHaP, not releasing anything to it, right? The next version of packages from this repo needs to be released from the release/cardano-node.1.35.x branch not master.

@coot correct, we are only replacing source-repository-packages with equivalent ones in CHaP.

[michaelpj]

Yes, this doesn't say anything about how you release your packages. It should help with releasing packages, in that if you have a "clean" cabal.project with CHaP, then you know that your released package will build downstream without any additional config. However, I'm not sure it's worth backporting these changes to the release branch just for that! We can do what we need to do for the 1.35 release and just take this forward on master.

[michaelpj]

bors r+

[michaelpj]

bors r+

[iohk-bors[bot]]

Already running a review

[michaelpj]

I don't understand what bors is saying. The status say "merge conflict", but there isn't one, and I can't rerun it?

[michaelpj]

bors r-

[iohk-bors[bot]]

Canceled.

[michaelpj]

bors r+

[michaelpj]

bors r-

[michaelpj]

bors r+

[iohk-bors[bot]]

Build failed:

• build (8.10.7, windows-latest)

[michaelpj]

I rebased on master and now the windows CI is failing because it can't find the system libsecp256k1 in order to build secp256k1-haskell. I don't think anything in this PR should affect that, so I'm quite confused. Any ideas?

[michaelpj]

Thanks for the comments Nick!

[michaelpj]

I think I've addressed all the comments. Just trying to work out why the windows CI doesn't like me :thinking: