ouroboros-network icon indicating copy to clipboard operation
ouroboros-network copied to clipboard
verified publisher icon IntersectMBO

Integrate the Conway era

Open nfrisby opened this issue 3 years ago • 7 comments

Fixes #3962. Integrates the Conway era.

Checklist

  • Branch
    • [ ] Commit sequence broadly makes sense
    • [ ] Commits have useful messages
    • [ ] New tests are added if needed and existing tests are updated
    • [ ] If this branch changes Consensus and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • [ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • [ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • [x] Self-reviewed the diff
    • [x] Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • [x] Reviewer requested

nfrisby avatar Aug 21 '22 20:08 nfrisby

Do we need to add the golden files for the new era?

dnadales avatar Aug 31 '22 12:08 dnadales

The three remaining CI failures are because we don't have a ConwayGenesis.json file yet for the cardano-tools test suite. I've pinged Jared and Jordan and John Ky for their thoughts on that.

nfrisby avatar Sep 07 '22 00:09 nfrisby

A status update. I think this PR is now feature complete. However, the commit history remains messy and there are likely some comments to add.

nfrisby avatar Sep 07 '22 22:09 nfrisby

The three remaining CI failures are because we don't have a ConwayGenesis.json file yet for the cardano-tools test suite. I've pinged Jared and Jordan and John Ky for their thoughts on that.

I think that this ledger PR https://github.com/input-output-hk/cardano-ledger/pull/3022 should unblock John's work to add a ConwayGenesis.json.

JaredCorduan avatar Sep 12 '22 16:09 JaredCorduan

Update: until we get further notice, the Consensus team is going to park this Conway PR. Please tell us if you need anything along these lines, if you are continuing to work on Conway-related things.

nfrisby avatar Sep 20 '22 15:09 nfrisby

@nfrisby is there any reason not to merge it now? it would be nice to have the new era integrated all the way into node.

JaredCorduan avatar Sep 26 '22 21:09 JaredCorduan

@disassembler @JaredCorduan @nfrisby I think these are the tasks that remain:

  • [ ] Review the pending comments (@nfrisby and I should do this)
  • [ ] Review the new commits I added.
  • [ ] Add https://github.com/input-output-hk/ouroboros-network/pull/4063/commits/b9e5768bd65930c7081bced172de5d164a0eff2d to this PR

I do not know if there are additional tasks that I did not capture.

dnadales avatar Oct 10 '22 15:10 dnadales

I hate to add another speedbump here, but: if we rebase this PR we should also add a (very celebratory!) scrivy entry 👍

nfrisby avatar Jan 31 '23 02:01 nfrisby

bors r+

dnadales avatar Feb 01 '23 11:02 dnadales

Timed out.

iohk-bors[bot] avatar Feb 01 '23 14:02 iohk-bors[bot]

bors r+

dnadales avatar Feb 01 '23 14:02 dnadales

Build succeeded:

iohk-bors[bot] avatar Feb 01 '23 16:02 iohk-bors[bot]