ouroboros-network icon indicating copy to clipboard operation
ouroboros-network copied to clipboard

CAD-4707 Pull out common ChainDbArgs from tests

Open bartfrenk opened this issue 3 years ago • 4 comments

Pull out common ChainDbArgs from tests

Factor out common values for the ChainDbArgs used in various tests, to make it easier to set up new ChainDB tests in the future.

Closes CAD-4707.

Checklist

  • Branch
    • [x] Commit sequence broadly makes sense
    • [x] Commits have useful messages
  • Pull Request
    • [x] Self-reviewed the diff
    • [x] Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • [x] Reviewer requested

bartfrenk avatar Aug 03 '22 13:08 bartfrenk

bors r+

bartfrenk avatar Aug 17 '22 07:08 bartfrenk

bors r+

bartfrenk avatar Aug 17 '22 10:08 bartfrenk

Canceled.

iohk-bors[bot] avatar Aug 17 '22 10:08 iohk-bors[bot]

bors r+

bartfrenk avatar Sep 07 '22 08:09 bartfrenk

Build failed:

iohk-bors[bot] avatar Sep 07 '22 09:09 iohk-bors[bot]

bors r+

bartfrenk avatar Sep 07 '22 12:09 bartfrenk

bors r+

bartfrenk avatar Sep 07 '22 12:09 bartfrenk

Already running a review

iohk-bors[bot] avatar Sep 07 '22 12:09 iohk-bors[bot]