ouroboros-network icon indicating copy to clipboard operation
ouroboros-network copied to clipboard
verified publisher icon IntersectMBO

Account for new ledger refactor.

Open lehins opened this issue 3 years ago • 2 comments

Recent PR to ledger: input-output-hk/cardano-ledger#2901 introduced a lot of breaking changes. This PR accounts for those changes.

Description

description of the pull request, if it fixes a particular issue it should link the PR to a particular issue, see ref

Checklist

  • Branch
    • [x] Commit sequence broadly makes sense
    • [x] Commits have useful messages
    • [ ] New tests are added if needed and existing tests are updated
    • [ ] If this branch changes Consensus and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • [ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • [ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • [ ] Self-reviewed the diff
    • [ ] Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • [x] Reviewer requested

lehins avatar Aug 02 '22 10:08 lehins

The fact that this PR, an integration of a massive refactor in the ledger, is only ~100 lines, is such a clear indication of what a spectacular job @edsko and @mrBliss did to abstract the ledger inside of consensus.

JaredCorduan avatar Aug 03 '22 12:08 JaredCorduan

bors merge

lehins avatar Aug 17 '22 20:08 lehins

Build succeeded:

iohk-bors[bot] avatar Aug 17 '22 21:08 iohk-bors[bot]