ouroboros-network icon indicating copy to clipboard operation
ouroboros-network copied to clipboard

Rename trace types

Open coot opened this issue 3 years ago • 3 comments

All trace types should follow the following naming convention Trace<NAME>. Furthermore, all traces configurable by cardano-node should use the same type name as the corresponding option.

This will simplify the process of finding the right option to enable a given tracer or finding the trace type corresponding to a given option.

coot avatar Jul 26 '22 08:07 coot

Please be aware that with the new tracing system these options disappear. Maybe you want to defer this change to a point after new-tracing has become the new standard?

jutaro avatar Jul 26 '22 08:07 jutaro

@jutaro the new tracing system is probably also using some kind of filtering of messages by tracer name, isn't it? If so is this derived from trace type name?

coot avatar Aug 02 '22 07:08 coot

Yes, it uses hierarchical names as you can see here: https://github.com/input-output-hk/cardano-node/blob/master/doc/new-tracing/tracers_doc_generated.md

jutaro avatar Aug 02 '22 07:08 jutaro