ouroboros-network icon indicating copy to clipboard operation
ouroboros-network copied to clipboard

Remove vestigial `NodeTo*Version` constructors

Open nfrisby opened this issue 4 years ago • 6 comments

Now that mainnet is in the Mary era, we need not successfully connect to peers that can't participate in the Mary era. Thus we can simplify the code by removing those older negotiable versions and whatever backwards-compatibility logic they've been carrying along in eg our serializers.

cc @coot

nfrisby avatar May 11 '21 14:05 nfrisby

Should we duplicate this issue in ouroboros-consensus?

dnadales avatar Nov 30 '23 14:11 dnadales

I don't think we need to duplicate this issue, since the integration of whichever ouroboros-network version includes this change will force the dead code to be reaped etc.

nfrisby avatar Nov 30 '23 22:11 nfrisby

@coot I removed the consensus labels---despite me opening it, this is a proper networking Issue, I think.

nfrisby avatar Nov 30 '23 22:11 nfrisby

Old NodeToNode versions were removed in #4985

What about also removing old NodeToClient versions?

amesgen avatar Oct 24 '24 15:10 amesgen

@amesgen do you have an advise which versions should be removed?

coot avatar Oct 25 '24 03:10 coot

Node 9.0.0/9.1.0 use latestReleasedNodeVersion = NodeToClientV_16 (src), and as every node must have upgraded to at least this version since Conway, we could remove everything below NodeToClientV_16.

amesgen avatar Oct 25 '24 08:10 amesgen