cardano-ledger icon indicating copy to clipboard operation
cardano-ledger copied to clipboard
verified publisher icon IntersectMBO

Bring back comments in the Conway cddl spec

Open klntsky opened this issue 1 year ago • 3 comments

Please provide more comments explaining the semantics, and avoid magic constants

E.g. for https://github.com/IntersectMBO/cardano-ledger/blob/411054e40b4e08350049e4eaffdf0cc5f73e9d91/eras/conway/impl/cddl-files/conway.cddl#L20

The old explainer was very useful

klntsky avatar Aug 02 '24 14:08 klntsky

One possible solution to this which would help better define the address is use the .abnfb control operator from: https://www.rfc-editor.org/rfc/rfc9165.html to help define these kinds of fields.

stevenj avatar Aug 09 '24 09:08 stevenj

@lehins missing details on vote constants in CDDL,

; no - 0 ; yes - 1 ; abstain - 2

ashisherc avatar Jan 08 '25 09:01 ashisherc

@lehins missing details for thresholds in CDDL,

https://github.com/IntersectMBO/cardano-ledger/blob/7683b73971a800b36ca7317601552685fa0701ed/eras/conway/impl/cddl-files/conway.cddl#L304

ashisherc avatar Jan 20 '25 12:01 ashisherc