cardano-ledger icon indicating copy to clipboard operation
cardano-ledger copied to clipboard

Conformance: POOL: Translate and adjust

Open aniketd opened this issue 1 year ago • 0 comments

Description

  • Move SpecTranslate.Conway and ExecSpecRule.Conway to SpecTranslate.Conway.Base and ExecSpecRule.Conway.Base respectively, so that we can have ExecSpecRule.Conway.Pool and SpecTranslate.Conway.Pool, going forward, we can make modules per rule.
  • Translate and adjust the inputs to POOL
  • Change pparamsSpec to TrueSpec since, doing this did not make any tests fail, in particular, and so PParams seemed to be over-constrained.

Resolves #4449

Checklist

  • [x] Commit sequence broadly makes sense and commits have useful messages
  • [x] New tests are added if needed and existing tests are updated
  • [x] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the versioning process.
  • [x] The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • [x] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • [x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • [x] Cabal files are formatted (use scripts/cabal-format.sh)
  • [x] hie.yaml has been updated (use scripts/gen-hie.sh)
  • [x] Self-reviewed the diff

aniketd avatar Jul 02 '24 12:07 aniketd