cardano-ledger icon indicating copy to clipboard operation
cardano-ledger copied to clipboard

Published 20 hours ago • verified publisher icon IntersectMBO

Restrict `PParamUpdates` values

Open lehins opened this issue 1 year ago • 2 comments

Some of the PParamUpdates need their bounds tighten up. This ticket tracks these important tasks:

  • [ ] - Identify which pparam updates need extra validation
  • [ ] - Decide on concrete ranges for the above pparam updates
  • [ ] - Implement validation for the actual PParamUpdates possibly with stricter deserializer or predicate checks in the rules.

lehins avatar Jul 18 '23 18:07 lehins

There's already something in the spec for this: paramsWellFormed. There may be some changes to this once I try to prove a bunch of properties, but who knows when that happens. I think you can safely take that list for now.

WhatisRT avatar Jul 19 '23 10:07 WhatisRT

Yes, that's exactly what this issue is about. Ensuring that PParamsUpdates are well formed.I just left out the details on how we need to do this. So, thank you for linking to the spec

lehins avatar Jul 19 '23 10:07 lehins

Well formedness of PParams as defined by the spec has been implemented.

There will also be a guradrail script in place that will take care of preventing Parameter change proposals that propose values outside of ranges specified by constitution

We also fixed the types of some of the parameters to reflect their actual width as used downstream in consensus

lehins avatar Mar 08 '24 00:03 lehins