cardano-ledger icon indicating copy to clipboard operation
cardano-ledger copied to clipboard

Get rid of redundant accessor functions

Open lehins opened this issue 3 years ago • 1 comments

Every era defines a whole bunch of accessor functions eg, inputs', outputs', etc. which are redundant and should be removed, while all use sites should be switched to corresponding lenses. In case of ShelleyMA it even defines a pattern synonym. That one should be removed as well

lehins avatar Nov 08 '22 22:11 lehins

In case of ShelleyMA it even defines a pattern synonym. That one should be removed as well

This part has been addressed in #3126

aniketd avatar Nov 09 '22 13:11 aniketd

They should first be deprecated and then we can get rid of them at some point later. Some parts have been addressed in https://github.com/IntersectMBO/cardano-ledger/pull/4973 but there are still synonyms like that lingering around.

lehins avatar Apr 09 '25 05:04 lehins

The only remaining undeprecated accessor functions I was able to find were in Alonzo, and I couldn't find any redundant patterns. If there are any that I've missed, please let me know.

neilmayhew avatar Apr 16 '25 00:04 neilmayhew

The only remaining undeprecated accessor functions I was able to find were in Alonzo, and I couldn't find any redundant patterns.

Yep, looking for those fields to deprecate was part of this ticket. I also think that it was only in Alonzo that we had those left over. Thank you for double checking.

lehins avatar Apr 16 '25 04:04 lehins