groupoffice icon indicating copy to clipboard operation
groupoffice copied to clipboard

/install/upgrade.php too slow

Open michalcharvat opened this issue 1 year ago • 11 comments

Any idea how to speed up /install/upgrade.php ? I have mentioned issues with performance after upgrade to 6.7.79 and although the cache was cleared a minute ago, next call takes about 1 minute sometimes more.

michalcharvat avatar May 23 '24 13:05 michalcharvat

Do you run it with multi instance?

mschering avatar May 23 '24 14:05 mschering

Yes and no, the same issue is also on dev with debug. Earlier I mentioned it took some time on instances where were a lot of changes however second call was much faster. Currently every install/upgrade call with the intention to reload caches etc take too long

michalcharvat avatar May 23 '24 14:05 michalcharvat

Strange, I don't see the same thing. Perhaps you can use xdebug to produce a profile?

mschering avatar May 24 '24 08:05 mschering

Fixed at least on my dev - one cron task which was managed externally by supervisor hadnt session write close in it. However it didnt help on productuion. Anyway closing because it looks like nothing related to GO self :-)

michalcharvat avatar Jun 07 '24 11:06 michalcharvat

Hmm too early - 347 240x EntityType->clearCache and 346 276x EntityType->__wakeup are huge numbers

image

michalcharvat avatar Jun 07 '24 12:06 michalcharvat

that's odd, I tried it here but EntityType::clearCache() is only called 87 times (for each entity I guess). Can you dive into the stack trace?

mschering avatar Jun 10 '24 07:06 mschering

Or are you running this on sse.php?

mschering avatar Jun 10 '24 07:06 mschering

Thanks for bringing this to my attention. There was a huge inefficiency in the SSE process which will be fixed in the next release.

mschering avatar Jun 10 '24 08:06 mschering

@mschering btw there is a bug if you are still using < PHP 8 - PushDispatcher.php:75 image

michalcharvat avatar Jun 12 '24 08:06 michalcharvat

Instances are not the same... I still didnt migrated all modules from 6.7 to 6.8 but at first look there is huge difference in the first call.. another thing could be the difference in performance between 7.4 and 8.x

GO 6.7 + PHP 7.4 image GO 6.8 + PHP 8.1 image

michalcharvat avatar Jun 13 '24 09:06 michalcharvat

Please retest with the next releases.

mschering avatar Jun 17 '24 07:06 mschering

The problem was found... one script was named with a capital letter at the start, which is automatically loaded by the class loader.

michalcharvat avatar Oct 24 '24 14:10 michalcharvat