groupoffice icon indicating copy to clipboard operation
groupoffice copied to clipboard

Core module unique index

Open michalcharvat opened this issue 2 years ago • 3 comments

@mschering Shouldnt be core_module unique index changed from name to name + package? Currently you are unable to install module that has same name as lets say community module but it is in different package. The module has own unique name so there are no troubles to run it however I am currently unable to install module like that. I guess I already mentioned similar thing in old version of module installer - Settings -> Modules - however it looks like the ui is probably fixed but there is problem in installer self.

michalcharvat avatar May 31 '23 15:05 michalcharvat

Yes you're totally right. I think we didn't change this yet as there are more things counting on a unique module name. One thing for sure is that a main panel in the layout adds a route #MODULENAME to the router. This would be a conflict. I have to test what happens with duplicate names in different packages.

mschering avatar Jun 01 '23 06:06 mschering

It looks like all GO.mainLayout.openModule have to be extended about package info. Perhaps module could be easily build from package + module name for all modules that are not part of community folder?

Also it would be really great if let me know whether or not do you plan to do anything with that. If there wont be any solution for 6.6 I have to rewrite namespace and rename the module.

michalcharvat avatar Jul 05 '23 14:07 michalcharvat

@mschering Tell you truth I played with the solution mentioned above for a while because I had to deploy new modules and it is a bit tricky. Until all modules won't have specified namespace - ie custom made, business, core etc... it will be big issue. I am currently using override to modify addDefaultRoutes but it only works for specific modules :/

michalcharvat avatar Aug 23 '23 15:08 michalcharvat