medley icon indicating copy to clipboard operation
medley copied to clipboard

TEdit: opening expanded menu causes error, break window

Open hjellinek opened this issue 6 months ago • 8 comments

This happens in a recent master and in rmk88--Split-screen-updates-and-color.

Open a file in TEdit. I'm not sure it matters what the file contains; this may happen with an empty document also.

Click the Expanded Menu menu item.

The menu appears, but so does a break window.

See the video:

https://github.com/user-attachments/assets/bdf2f0e3-3be2-4df3-976c-6e8e85601af3

hjellinek avatar May 28 '25 20:05 hjellinek

It looks like the menu came up OK, and then you tried to do something else, reshape.move or something? Can you say what you did after the menu came up?

rmkaplan avatar May 28 '25 21:05 rmkaplan

I didn't do anything. The menu came up, and so did the break window. In that recording, after the menu opened I dragged the break window into the screen area I was recording.

hjellinek avatar May 28 '25 21:05 hjellinek

It does it for me, too. TEDITSYSTEMDATE 31-Mar-2025 12:04:23. Plain text file but named {dsk}/tmp/sample.tedit It also opens it twice when I open a new TEDIT window and then use middle-button in title bar to GET the file - both the original window and a new one show up with the same contents loaded.

nbriggs avatar May 28 '25 22:05 nbriggs

That TEDITSYSTEMDATE isn't meaningful, it seems to be just a variable that was set when the particular file TEDIT was last made. I'll should probably make that be a function that returns the date of the most recent loaded Tedit file.

I do see a problem wherein it doesn't notice that a particular menu is up and so brings it up again.

But I am now able to get the break.

On May 28, 2025, at 3:12 PM, Nick Briggs @.***> wrote:

nbriggs left a comment (Interlisp/medley#2172) https://github.com/Interlisp/medley/issues/2172#issuecomment-2917730714 It does it for me, too. TEDITSYSTEMDATE 31-Mar-2025 12:04:23. Plain text file but named {dsk}/tmp/sample.tedit It also opens it twice when I open a new TEDIT window and then use middle-button in title bar to GET the file - both the original window and a new one show up with the same contents loaded.

— Reply to this email directly, view it on GitHub https://github.com/Interlisp/medley/issues/2172#issuecomment-2917730714, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSTUJL4OR5OGSK3ACWMLMD3AYYFPAVCNFSM6AAAAAB6DZUGUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJXG4ZTANZRGQ. You are receiving this because you were assigned.

rmkaplan avatar May 28 '25 22:05 rmkaplan

@rmkaplan, did you mean "I am not able to get the break"?

I just tried it in a guest account on online.interlisp.org and didn't get the break either with a brand-new TEdit window.

However, I was able to reproduce the problem with an existing file:

Create a new file in TEdit, write it to disk. Close TEdit. Open the FileBrowser, Edit the file you just created (in TEdit). Click on Expanded Menu, et voila.

Image

hjellinek avatar May 28 '25 22:05 hjellinek

No, I'm getting it now. The problem was a string not matching an atom, but only when it was trying to turn on the button to tell you that the file that you already got into the window was in fact unformatted.

I'm not sure why he put that button on that particular line of the menu. It would make more sense if it was on the line with the Get and Put: telling it that you want to get/put the file as unformatted. I think I'll move it.

In this situation, when you are getting an unformatted file, it is apparently trying to turn on the button to tell you that that's what you did, even if you did it by setting a property in a separate call to Tedit.

On May 28, 2025, at 3:48 PM, Herb Jellinek @.***> wrote:

hjellinek left a comment (Interlisp/medley#2172) https://github.com/Interlisp/medley/issues/2172#issuecomment-2917784977 @rmkaplan https://github.com/rmkaplan, did you mean "I am not able to get the break"?

I just tried it on online.interlisp.org and didn't get the break either.

— Reply to this email directly, view it on GitHub https://github.com/Interlisp/medley/issues/2172#issuecomment-2917784977, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSTUJKKVQ3TLBJ3G37BRPT3AY4KDAVCNFSM6AAAAAB6DZUGUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJXG44DIOJXG4. You are receiving this because you were mentioned.

rmkaplan avatar May 28 '25 22:05 rmkaplan

This never happened to me and I can't reproduce it on Linux Mint 22.1 Cinnamon. Medley VNC on master, both Medley and Maiko.

pamoroso avatar May 29 '25 09:05 pamoroso

It only happened when the file you open was an unformattted plaintext file. I didn't see it at first because my plaintext test file had become formatted somewhere along the way.

On May 29, 2025, at 2:49 AM, Paolo Amoroso @.***> wrote:

pamoroso left a comment (Interlisp/medley#2172) https://github.com/Interlisp/medley/issues/2172#issuecomment-2918884757 This never happened to me and I can't reproduce it on Linux Mint 22.1 Cinnamon. Medley VNC on master, both Medley and Maiko.

— Reply to this email directly, view it on GitHub https://github.com/Interlisp/medley/issues/2172#issuecomment-2918884757, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSTUJO3EWQ46FH6HRT7RDT3A3J4FAVCNFSM6AAAAAB6DZUGUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJYHA4DINZVG4. You are receiving this because you were mentioned.

rmkaplan avatar May 30 '25 02:05 rmkaplan