APPLY in TEdit Page Layout Menu will fail (sort of silently) whenever Page Numbers is set to Yes

[fghalasz]

APPLY in TEdit Page Layout Menu will fail whenever Page Numbers is set to Yes. The error message in the prompt window will be "Please set both X and Y locations for page numbers". The APPLY fails to cpmplete - although the error message does not say this.

I tried bypassing the check for page numbers in \TEDIT.CHANGE.PAGELOOKS, but the APPLY then breaks under TEDIT.SINGLE.PAGEFORMAT.

There is no field for Page Number X and Y in the Page Layout Menu. Looks like it has to be added in and handled by both SHOW and APPLY

APPLY in TEdit Page Layout Menu works as expected when Page Numbers is set to No.

[rmkaplan]

This was on a path that I didn't quite finish, I backed it but apparently I didn't go back far enough.

With respect to page numbers, the pagelooks menu repeats the font selection of the charlooks menu but otherwise is kind of inflexible, only allows for very minimal formatting (text after, text before, alignment). A better alternative is to treat page numbers as heading paragraphs where the number itself is inserted by a page-number image object. Then you get the full range of character and paragraph formatting, and eliminate a lot of complexity and redundancy.

So the basic scheme is implemented, the problem was then how to map the old way that page numbers are specified, not in the menu but in existing documents, into that new underlying framework. I got so far, decided there were more pressing things, so I saved it for later and backed out...sort of.

I'll resurrect the earlier stuff.

[rmkaplan]

I'm going to put this fix in a separate PR after #2119 is approved and merged. I'll restore the previous menu behavior, but I think I'll put another option--Header--in addition to Yes/No.

That would clarify that page numbers are intended to come from a page-number header paragraph and not from this part of the menu. Technically, with respect to this menu and all the other properties here, Header is the same as No. But it would seem odd for the user to say No and still get page numbers. What really controls the header page numbers is whether the header containingg the object is specified along with other headers for the page in the Header section of the menu.

The pagenumber image object deals with roman/arabic, its character looks are from the normal character-looks menu, its X/Y position is the position of the header on this page type.