medley icon indicating copy to clipboard operation
medley copied to clipboard

Loadup says SUCCESS when it actually failed

Open rmkaplan opened this issue 1 year ago • 5 comments

Describe the bug If a Lisp error happens during the loadup-full.sh script, a full.sysout is created in the loadups directory and the terminal window reports SUCCESS.

But in fact, the loadup failed, files after the error are not included. The sysout is smaller than it should be, as shown in this screen shot: Screenshot 2024-05-20 at 9 44 23 PM

Note also that the full.dribble file is garbage.

To Reproduce Steps to reproduce the behavior:

  1. Pick a file that is loaded during the loadup-full process, add (P (ERROR)) to its commands, run loadup-full.sh.

A too-small and incomplete full.sysout shows up in the loadups directories. The shell script reports SUCCESS

Expected behavior The shell script reports FAILURE, the sysout file doesn't show up in the loadups directory. It would be nice, to help in debugging the source of the error, if the dribble file was intact.

Screenshots If applicable, add screenshots to help explain your problem.

Context (please complete the following information):

  • OS: Mac
  • OS Version: Sonoma 14.1
  • Host arch: arm64,

rmkaplan avatar May 21 '24 04:05 rmkaplan

Is there a function that can be called from Lisp that takes it into URAID (perhaps with a message)?

If so, then perhaps we can signal failure by wrapping the various loadup functions under NLSETQs, and dropping into URAID on error. And then, maybe doing URAID's hard-reset or quit commands would get back to a debuggable state inside the sysout.

rmkaplan avatar May 25 '24 17:05 rmkaplan

Is there a function that can be called from Lisp that takes it into URAID (perhaps with a message)?

(RAID "message1")

nbriggs avatar May 25 '24 17:05 nbriggs

normally if a loadup fails, it doesn't thwn go on and do the MAKESYS. or make a new whereis.hash, etc

that was the reason for the 'toudh' of the timestamp file. Failure can happen for too many unpreductavke reasona to guard against it with a NLSETQ.

masinter avatar May 25 '24 21:05 masinter

That's not true: if you put an ERROR explicitly in the loadup function, the MAKESYS gets made and moved to loadups

rmkaplan avatar May 25 '24 22:05 rmkaplan

I think if an error happens during LOADUP-FULL it should error, enter a break. set NLSETQGAG to NIL.

masinter avatar May 26 '24 17:05 masinter