omid_v1_present iframe missing sandbox attribute

[bjoberg]

Overview

The iframe created to detect if omid is present, or not, does not contain a sandbox attribute.

Current output:

<iframe id="omid_v1_present" name="omid_v1_present" style="display: none;">
...
</iframe>

Desired output:

<iframe id="omid_v1_present" name="omid_v1_present" style="display: none;" sandbox>
...
</iframe>

Code reference.

Why is this a problem?

This is a problem because the sandbox attribute "controls the restrictions applied to the content embedded in the

What can be done?

Add sandbox to the iframe.

[nlehrer]

Yes, I think adding the sandbox attribute should be fine. See #31 for discussion of how it will be merged.

[nlehrer]

The change in the upstream repo was merged and will be included in v1.4.6 which is being released at the moment (should appear in this repo today or Monday).

[bjoberg]

Amazing 🙌🏼. Thanks for your support!!