eslint-plugin-react-native [fix] Check styles that was imported from other file

[fix] Check styles that was imported from other file

Open retyui opened this issue 2 years ago • 13 comments

Issue: https://github.com/Intellicode/eslint-plugin-react-native/issues/165#issuecomment-983636750

Dec 05 '21 03:12 retyui

Demo

https://user-images.githubusercontent.com/4661784/144732862-17b64c75-260b-48a4-a0b3-fd50c9fbf63c.mp4

Dec 05 '21 03:12 retyui

@Intellicode I see that all last pipelines on a master branch are red failed.

For me as a contributor is important that nothing was broken when I made changes

Dec 05 '21 14:12 retyui

@Intellicode I see that all last pipelines on a master branch are red failed.

For me as a contributor is important that nothing was broken when I made changes

@retyui, I agree and I understand, unfortunately the effort required to make all (updated) dependencies compatible with each other is more than I wished. Hope to have a working build soon.

Thanks for your PR!

Dec 05 '21 15:12 Intellicode

Feel free to re-integrate the main branch, I think it's fixed now!

Dec 05 '21 16:12 Intellicode

@Intellicode so fast 👍 that's incredible!! I will check my PR now

Dec 05 '21 16:12 retyui

@Intellicode I've just added tests for new code, and found & fixed a small bug)

Azure Pipelines now green!
But SonarCloud failed, and want's to fix 21.4% Duplication

I don't know how to mark no-unused-styles.experimental.js as excluded file to calculate the duplication

you can review PR @Intellicode

Dec 05 '21 18:12 retyui

@retyui Thanks for updating! Please allow some time for a review, since it is a big PR. It looks very nice and useful though!

Dec 06 '21 18:12 Intellicode

@Intellicode did you have time to check PR?

Dec 13 '21 17:12 retyui

@retyui, sorry not yet! I'm afraid it will be after Christmas due to my availability.

Dec 13 '21 18:12 Intellicode

@Intellicode another polite reminder

Jan 11 '22 08:01 retyui

@Intellicode another polite reminder

Sorry, I didn't find availability yet to have a proper look, unfortunately I'm unable to rush it, since this PR introduces two new dependencies ("eslint-import-resolver-node": "^0.3.6", "eslint-module-utils": "^2.7.1"), I will have to vet them as well, that will take more time.

Jan 11 '22 16:01 Intellicode

SonarCloud Quality Gate failed.