PlotSquared icon indicating copy to clipboard operation
PlotSquared copied to clipboard

No exception handling for PlotSquared unable to paste schematic

Open braceyourself07 opened this issue 1 year ago • 0 comments

Server Implementation

Paper

Server Version

1.20.4

Describe the bug

There is no error handling or log output when a schematic cannot be pasted in PlotSquared (e.g. using /plot backup or /plot schematic).

In Discord, Pierre referenced these two areas of code:

https://github.com/IntellectualSites/PlotSquared/blob/main/Core/src/main/java/com/plotsquared/core/command/Backup.java#L340

https://github.com/IntellectualSites/PlotSquared/blob/main/Core/src/main/java/com/plotsquared/core/backup/PlayerBackupProfile.java#L203

This causes no error or any other output in console or logs when PlotSquared fails to paste a schematic. I only receive the error message "The backup could not be restored: Failed to paste the schematic."

image

To Reproduce

  1. /plot backup save
  2. /plot backup load 1

Expected behaviour

No backup is restored despite backups being enabled, a backup present in the /plugins/PlotSquared/backups folder, and the schematic otherwise works when manually uploaded. I have not tested but may also affect paste-on-claim.

Screenshots / Videos

No response

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/18bc3af74e1f4306bcc1acea45ea1820

PlotSquared Version

7.3.8-Premium

Checklist

  • [X] I have included a Plot debugpaste.
  • [X] I am using the newest build from https://www.spigotmc.org/resources/77506/ and the issue still persists.

Anything else?

I am using an older version of FAWE (build 743) because I haven't updated to java 21 yet. Not sure if this is related.

braceyourself07 avatar Jul 27 '24 19:07 braceyourself07