PlotSquared
PlotSquared copied to clipboard
IntellectualSites
music flag not working.
Server Implementation
Paper
Server Version
1.20.4
Describe the bug
Even if you use the flag set music ~ command, background music is not set.
To Reproduce
.
Expected behaviour
.
Screenshots / Videos
No response
Error log (if applicable)
No response
Plot Debugpaste
.
PlotSquared Version
PlotSquared-7.3.2-Premium
Checklist
- [X] I have included a Plot debugpaste.
- [X] I am using the newest build from https://www.spigotmc.org/resources/77506/ and the issue still persists.
Anything else?
No response
Have you set the "Music" slider to > 1? If not, that's the reason why.
In hindsight it's kind of dumb of me to set the sound category for the plot music flag to "music" potentially - I guess Jukebox/Note-Blocks would've been a better choice? Tho it does make sense in that category as well.
Have you set the "Music" slider to > 1? If not, that's the reason why.
In hindsight it's kind of dumb of me to set the sound category for the plot music flag to "music" potentially - I guess Jukebox/Note-Blocks would've been a better choice? Tho it does make sense in that category as well.
Could be moved over, but the lack of steps to reproduce included in the issue, don't really work towards a confident issue at all.
to reproduce:
- Set /p flag set music RELIC on your own plot
- Hear out for no music, only minecraft default music can appear, but no music disk
I hear default music, also the normal jukebox but no plot music https://athion.net/ISPaster/paste/view/dcc35ce7a53141419881739a12cb8338
to reproduce:
Set /p flag set music RELIC on your own plot
Hear out for no music, only minecraft default music can appear, but no music disk
I hear default music, also the normal jukebox but no plot music
https://athion.net/ISPaster/paste/view/dcc35ce7a53141419881739a12cb8338
Mhm, I had issues with sometimes not hearing any music and sometimes hearing the totally wrong music before my change(s) - but that's weird as it did work for me on 1.20.4. Someone / I'll have to look into that I guess.
I tested and noticed no music in the current February 2024 builds . /plot music and choosing a disc works but can not hear any music. .
https://athion.net/ISPaster/paste/view/14a3d53ed00a478899c412c639319f8e
I suspect that there is a mistake in this commit 9566af5fda7ec01d95e7f3ec5508f34de1e21c00 , because prior commit works.
I reverted back to this commit a1d94af242751bdb4f53b9693f07faa316b4abfb and music is working
Can not tell , music from plot is not heard , no matter where i set the volume slider to. just noticed that something wrong in that commit i indicated above . I works fine in previous commit.
I really don't see how that commit should've broke that at all tbh. It even worked for me on 1.20.4 Paper.
The javadocs only state:
This function will fail silently if Location or Sound are null. No sound will be heard by the player if their client does not have the respective sound for the value passed.
But sound parsing has not changed at all, and the location can't be null.
All I can tell you is from that commit onward on Paper 1.20.4 current builds the sound is not heard from plot music discs. I will try reversing that commit and compile the latest PS
I really don't see how that commit should've broke that at all tbh. It even worked for me on 1.20.4 Paper.
The javadocs only state:
This function will fail silently if Location or Sound are null. No sound will be heard by the player if their client does not have the respective sound for the value passed.
But sound parsing has not changed at all, and the location can't be null.
Hi Pierre, I could not figure out why your music flag commit is not working. I tested again on a local server on my home system , same results. The only fix was to undo your commit and compile current code . Sorry I couldnt be much help, I guess you could reverse it so that others dont have issues and revisit the patch another day. Not everyone uses the /plot music , as plot is used by new players visiting the server unit they get promoted and build on the main maps
I am surprised that this commit has not been fixed yet , https://github.com/IntellectualSites/PlotSquared/commit/9566af5fda7ec01d95e7f3ec5508f34de1e21c00 . It simply did not work in 1.20.4 Paper . To test , compile latest build to date and goto a plot and do /plot music and select a Disc. Nothing is heard with volume at 100 percent .
I'm sorry - I found the error which I just couldn't see. Will be fixed with https://github.com/IntellectualSites/PlotSquared/pull/4391