PlotSquared icon indicating copy to clipboard operation
PlotSquared copied to clipboard

Untrusted players can trigger redstone with torches in comparators.

Open ch4ika opened this issue 1 year ago • 5 comments

Server Implementation

Paper

Server Version

1.20.2

Describe the bug

An untrusted player can trigger a redstone signal by placing a redstone torch into machines with comparators.

To Reproduce

  1. Build the machine as shown in the picture.
  2. It is important that there is an item in the chest.
  3. A player who has no rights to the plot needs a redstone torch.
  4. And now the untrusted player can place the torch on one of the purple wool blocks and trigger this machine.

Expected behaviour

Redstone should not be triggered by other untrusted players.

Screenshots / Videos

2023-10-18_20 05 02 2023-10-18_20 05 16

Error log (if applicable)

No response

Plot Debugpaste

https://athion.net/ISPaster/paste/view/9d58ea13a2b5424b84a45a556533e43e

PlotSquared Version

7.0.0-rc.4-Premium

Checklist

  • [X] I have included a Plot debugpaste.
  • [X] I am using the newest build from https://www.spigotmc.org/resources/77506/ and the issue still persists.

Anything else?

No response

ch4ika avatar Oct 18 '23 18:10 ch4ika

Hello, can you update to latest plotsquared and retry please?

OneLiteFeather avatar Oct 19 '23 20:10 OneLiteFeather

Still on 7.1.0-Premium

ch4ika avatar Oct 19 '23 21:10 ch4ika

Can reproduce it, it works because the redstone torch can trigger the update chain of minecraft. It is an indirect block update and triggers the redstone comparator. Important to reproduce: use a trapped chest.

OneLiteFeather avatar Oct 20 '23 12:10 OneLiteFeather

redstone-torch-bug

Same on a 1.19.4 server. The problem occurs only with BUDs (Block Update Detectors). WorldGuard does not prevent the case either. The problem has existed for some time. This may not be fixable with a simple event listener cancel.

RedstoneFuture avatar Oct 29 '23 21:10 RedstoneFuture

If it's also an issue with WorldGuard I'm assuming there's definitely no easy solution we can add to P2 either tbh

dordsor21 avatar Dec 03 '23 14:12 dordsor21

This Issue can be closed due to it being fixed by paper

Tamikaschu avatar May 26 '24 23:05 Tamikaschu

This Issue can be closed due to it being fixed by paper

Thank you! We should still test it before we close it here.

RedstoneFuture avatar May 26 '24 23:05 RedstoneFuture