PlotSquared icon indicating copy to clipboard operation
PlotSquared copied to clipboard

Adding & Trusting inserts data in the wrong table

Open NotMyFault opened this issue 4 years ago • 1 comments

  • /plot add inserts into plot_trusted
  • /plot trust inserts into plot_helpers

Currently this doesn't cause issues because the relevant calls such as Plot#isAdded() use the inverted methods internally which return the value expected. This may cause issues/confusion if you access the tables directly. Per-design, plot add inserts into plot_helpers, because added members are internally referenced as helpers and plot trust goes into plot_trusted. Addressing this issue must be done with caution to not screw up data down the line.

NotMyFault avatar Jun 08 '21 12:06 NotMyFault

I actually just noticed this bug too and was about to open an issue about it. I noticed it due to the get here returning the wrong table names.

Phoenix616 avatar Jun 10 '21 13:06 Phoenix616