FastAsyncWorldEdit icon indicating copy to clipboard operation
FastAsyncWorldEdit copied to clipboard

fix: add a WrapperChunk to allow "Invalidating" a ChunkHolder on submission

Open dordsor21 opened this issue 2 months ago • 2 comments

  • fixes issues where edits were not fully undone
  • invalidate a ChunkHolder when submitting, via a "wrapper" to allow filters to be "aware"/forced to use a new ChunkHolder when it is submitted
  • this also allows us to not submit a ChunkHolder in IQueueExtent#filter if the wrapper does not holder it anymore (i.e. it was forcibly submitted, and no more work was done)

dordsor21 avatar Oct 26 '25 22:10 dordsor21

~Yet to test with postProcessing history (ran out of time). Would also like to investigate if there's any performance hit (unlikely but you never know).~

Looks like it works fine + nothing new comes up in profiler

Would also be good if others could test and try to reproduce the issue with history (to see if it's "definitely fixed")

dordsor21 avatar Oct 26 '25 22:10 dordsor21

@SirYwell poke

dordsor21 avatar Nov 30 '25 19:11 dordsor21