IntellectualSites
fix: hollow on large areas fails
Overview
Fixes #2897
Description
Determine the appropriate BlockVector3Set implementation by the region (or rather it's size). Seems to work, as no error is thrown after 30ish seconds anymore (but I haven't waited for the hollow to complete on > 1bil blocks - chunk gen takes ages)
### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).
There are quite a few cases of hardcoding the use of the LocalBlockVectorSet - and not using BlockVector3Set.getAppropriateVectorSet - though most of them are either unlikely to have a larger amount of vectors or it can't be predicated.
There are quite a few cases of hardcoding the use of the LocalBlockVectorSet - and not using BlockVector3Set.getAppropriateVectorSet - though most of them are either unlikely to have a larger amount of vectors or it can't be predicated.
So if I understand correctly, there are many uses in the plugin of the original method however as it is unlikely to encounter said error or the error is simply unpredicted, it remained unfixed to my error report (and one other which then got fixed temporarily I think)?
And as for the function part it's just they used a sort of Bruteforce, do it all at once verses actually optimizing that part and making it go in proper sizes, and sections automatically I think based on the term (hardcoded) and my understanding of the changed line. Does sound at all close to correct? (I'm just trying to understand)
Your issue is fixed by this PR. I just noted, that other commands might create a similar error - but it is extremely unlikely.