FastAsyncWorldEdit icon indicating copy to clipboard operation
FastAsyncWorldEdit copied to clipboard

ExtentEntityCopy does nothing when used with a non-IChunkExtent

Open opl- opened this issue 2 years ago • 1 comments

Server Implementation

Paper

Server Version

1.20.2

Describe the bug

ExtentEntityCopy hits the default implementation of Extent.createEntity

https://github.com/opl-/FastAsyncWorldEdit/blob/f812fc14abdd23d3d131395f02d5526dd8095389/worldedit-core/src/main/java/com/sk89q/worldedit/extent/Extent.java#L147

when trying to use it with a BukkitAdapter.adapt(world). A quick investigation leads to the following line:

https://github.com/opl-/FastAsyncWorldEdit/blob/79a2c14caacee4fdd64e51e43fde382118750781/worldedit-bukkit/src/main/java/com/sk89q/worldedit/bukkit/BukkitWorld.java#L170

IChunkExtent, being a FAWE construct, breaks compatibility.

To Reproduce

Use reproduction steps from #2445.

Expected behaviour

Some sorta automatic fallback? Not sure.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/f05eca59ab7a4e188ced658f1f9ffa4c

Fawe Version

FastAsyncWorldEdit version 2.8.0

Checklist

  • [X] I have included a Fawe debugpaste.
  • [X] I am using the newest build from https://ci.athion.net/job/FastAsyncWorldEdit/ and the issue still persists.

Anything else?

No response

opl- avatar Oct 06 '23 07:10 opl-

Ultimately, using FAWE without an IChunkExtent is quite pointless as the methods are otherwise the same as WE, and should realistically be used synchronously. FAWE only created an interface between async and sync for non chunk extents (i.e. WNA) by scheduling chunks of the task on the main thread

dordsor21 avatar Dec 05 '24 21:12 dordsor21