FastAsyncWorldEdit icon indicating copy to clipboard operation
FastAsyncWorldEdit copied to clipboard

Remove alpha option, or repurpose it as a "strength" on #saturate pattern

Open OneLiteFeather opened this issue 2 years ago • 4 comments

Server Implementation

Paper

Server Version

1.20.1

Describe the bug

Due to a player request, @TheMeinerLP and I investigated how #saturate works and found out that the alpha (which is the tranparency) always has to be 255 in order to work.

To Reproduce

  1. Do //re #saturate[0][255][0][1] and set the 1 to a number that is not 255 and below
  2. See after a minute that it won't work

Expected behaviour

It should work and the transparency should be applied -> glass might be set then or something more transparent

Screenshots / Videos

No response

Error log (if applicable)

None

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/4a7ba67d0e8347b9ae6d553dd08ff988

Fawe Version

Is not important here, see info below (we had several tests running at this version and latest 2.7.2)

Checklist

  • [X] I have included a Fawe debugpaste.
  • [X] I am using the newest build from https://ci.athion.net/job/FastAsyncWorldEdit/ and the issue still persists.

Anything else?

This issue is since 2021 in the code at this place: https://pastebin.com/HK9giLqt

OneLiteFeather avatar Sep 22 '23 12:09 OneLiteFeather

Would be nice also to expose some API functions from TextureUtil as API for everyone

TheMeinerLP avatar Sep 22 '23 20:09 TheMeinerLP

Currently TextureUtil requires an exact alpha-level match to allow for a block to be selected

dordsor21 avatar Sep 30 '23 10:09 dordsor21

How to make this better for the user that only has a parameter to put in and might not know which exact alpha values they have to put in? Should we add good examples in documentation or some fixed value options in tabcompletion at the alpha value?

OneLiteFeather avatar Sep 30 '23 13:09 OneLiteFeather

I would say just remove the alpha option, or repurpose it as a "strength". I.e. 255 is mixing 100% of either colour, whereas alpha=0 would effectively be not mixing the "new" colour at all

dordsor21 avatar Sep 30 '23 14:09 dordsor21