realsense-ros icon indicating copy to clipboard operation
realsense-ros copied to clipboard

Allow parametrizing list of reset errors

Open paulbovbel opened this issue 5 years ago • 6 comments

Addresses #889

Allow a parameter to configure which hardware errors will force a camera reset.

paulbovbel avatar Oct 11 '19 16:10 paulbovbel

I feel that the whole "reset" option is a "necessary evil", until a permanent solution with firmware, kernel or driver is available. Therefor, although I have no strong and specific objection to your suggestion, I'm reluctant to add additional code in that section.

doronhi avatar Dec 09 '19 14:12 doronhi

For the sake of realsense users, I'd urge you to consider including this until "necessary evil" isn't necessary anymore.

paulbovbel avatar Dec 13 '19 14:12 paulbovbel

What other error messages do you find necessary to include, in addition to the 3 already included?

doronhi avatar Dec 15 '19 05:12 doronhi

usb_scp_overflow and rec_error both drop the stream, which is recoverable via the soft reset mechanism.

paulbovbel avatar Dec 15 '19 15:12 paulbovbel

This needs a rebase now :(

amilcarlucas avatar Dec 17 '20 11:12 amilcarlucas

I'm still using this regularly, but I didn't get the impression maintainers were interested in merging it. If they are, happy to rebase.

paulbovbel avatar Dec 17 '20 15:12 paulbovbel