realsense-ros
realsense-ros copied to clipboard
Allow parametrizing list of reset errors
Addresses #889
Allow a parameter to configure which hardware errors will force a camera reset.
I feel that the whole "reset" option is a "necessary evil", until a permanent solution with firmware, kernel or driver is available. Therefor, although I have no strong and specific objection to your suggestion, I'm reluctant to add additional code in that section.
For the sake of realsense users, I'd urge you to consider including this until "necessary evil" isn't necessary anymore.
What other error messages do you find necessary to include, in addition to the 3 already included?
usb_scp_overflow and rec_error both drop the stream, which is recoverable via the soft reset mechanism.
This needs a rebase now :(
I'm still using this regularly, but I didn't get the impression maintainers were interested in merging it. If they are, happy to rebase.