librealsense icon indicating copy to clipboard operation
librealsense copied to clipboard
verified publisher icon IntelRealSense

If fw.res file required when use target realsense2::fw

Open PhoebeHui opened this issue 5 years ago • 11 comments

Hi All,

The fw.res file required to build the fw.lib, I want to confirm if it's required when use the fw.lib?

I noticed fw.res set to INTERFACE_LINK_LIBRARIES for target realsense2::fw in https://github.com/IntelRealSense/librealsense/blob/master/common/fw/CMakeLists.txt#L50, it would export the target in realsense2Targets.cmake, however, it's not installed, so this would cause usage issue when using the library.

In realsense2Targets.cmake file:

set_target_properties(realsense2::fw PROPERTIES
  INTERFACE_LINK_LIBRARIES "F:/VCPKG/clean/buildtrees/realsense2/x64-windows-rel/common/fw/fw.res"
)

Thank you in advance!

Thanks, Phoebe

PhoebeHui avatar Dec 09 '20 07:12 PhoebeHui

@PhoebeHui Thanks you for pointing out this! This should be a bug. Already forwarded to our engineering team and will let you know if any update. Thanks!

RealSenseSupport avatar Dec 30 '20 01:12 RealSenseSupport

Any progress?

PhoebeHui avatar Jun 09 '21 06:06 PhoebeHui

@PhoebeHui Sorry, there's no update yet. When get any update will let you know. Thanks!

RealSenseSupport avatar Jun 09 '21 07:06 RealSenseSupport

@PhoebeHui , the file fw.lib is an internal SDK resource used in make's build. It is not part of the public API and wouldn't be exported.

Did you encounter an issue with the specific target ? Please clarify.

ev-mp avatar Aug 23 '21 06:08 ev-mp

@PhoebeHui Do you still have any questions with the clarification from ev-mp? Looking forward to your update. Thanks!

RealSenseSupport avatar Sep 24 '21 01:09 RealSenseSupport

@RealSenseSupport, sorry for late response, I will try to update this port in vcpkg next week, and double check this issue in new release, I will get back to you soon.

PhoebeHui avatar Sep 24 '21 07:09 PhoebeHui

@PhoebeHui , the file fw.lib is an internal SDK resource used in make's build. It is not part of the public API and wouldn't be exported.

Then it should not be set to INTERFACE_LINK_LIBRARIES for target realsense2::fw.

@ev-mp @RealSenseSupport, this problem still exists in latest release revision 2.49.0.

You can repro this issue:

  1. Get changes from https://github.com/microsoft/vcpkg/pull/20379
  2. ./bootstrap-vcpkg.bat
  3. ./vcpkg install realsense2:x64-windows
  4. Check ./vcpkg/installed/share/realsense2/realsense2Targets.cmake, it still requires 'common/fw/fw.res' file.
  INTERFACE_LINK_LIBRARIES "F:/VCPKG/clean/buildtrees/realsense2/x64-windows-rel/common/fw/fw.res"

PhoebeHui avatar Sep 27 '21 08:09 PhoebeHui

This exact problem still persists (using vcpkgs last version of realsense2 2.50.0).

xaedes avatar Jan 27 '22 20:01 xaedes

@PhoebeHui / @xaedes can you check on latest version 2.56. per my check, the path is now relative and not absolute. thanks gil

gilpazintel avatar Feb 03 '25 15:02 gilpazintel

@PhoebeHui @xaedes Did you get chance to try with the latest librealsense v2.56.3 to see if the issue resolved or not? Looking forward to your update. Thanks!

RealSenseCustomerSupport avatar Feb 14 '25 03:02 RealSenseCustomerSupport

@PhoebeHui @xaedes We didn't get update from your side for two weeks. As the issue was resolved already, close this ticket accordingly. Please feel free to create another ticket if you still have any issue. Thanks!

RealSenseCustomerSupport avatar Mar 04 '25 04:03 RealSenseCustomerSupport