librealsense
librealsense copied to clipboard
IntelRealSense
android-examples-recording-plus
What is the purpose of the change
Solve #9989 #10310 #10007 #8551 #5446，and give a unified and complete solution. Make changes on the basis of the https://github.com/IntelRealSense/librealsense/tree/master/wrappers/android/examples/recording example in the Android sample program, introduce the openCV library, realize pressing the snapshot button, save the aligned color map, pseudo-color depth map, and grayscale depth map locally on the Android device, and use the getData method to save The depth data is a .csv file.
Does this pull request potentially affect existing recording functions？
No. Snapshot and recording are two independent processes and do not affect each other. Users can choose to press the snapshot button to save the frame data at a certain moment to the Android local or press the recording button to record a complete bag file for a certain period of time according to their own needs.
Hi @oddityyyy This PR is so big!
- please rebase your code base to the current development branch.
- too many codes have been changed outside of the Android wrapper folder. for example, csharp/dlib/matlab/nodejs/open3d/opencv/openvino/pcl/pointcloud/python/unrealengine4... some of them have been changed/removed in previous release version. I think you should not modify them.
- is it possible that move opencvlibray out of this repo? or add opencv using .gitsubmodule?
- both "capture" and "recording" are changed. but in the description of this PR, only one modified example is "recording". do you want to change all of them?
- which version of Android Studio are you using?
and one more question, why do saving .jpg files instead of extracting pictures from the recorded .bag file?
Thx.
Hi @oddityyyy This PR is so big!
- please rebase your code base to the current development branch.
- too many codes have been changed outside of the Android wrapper folder. for example, csharp/dlib/matlab/nodejs/open3d/opencv/openvino/pcl/pointcloud/python/unrealengine4... some of them have been changed/removed in previous release version. I think you should not modify them.
- is it possible that move opencvlibray out of this repo? or add opencv using .gitsubmodule?
- both "capture" and "recording" are changed. but in the description of this PR, only one modified example is "recording". do you want to change all of them?
- which version of Android Studio are you using?
and one more question, why do saving .jpg files instead of extracting pictures from the recorded .bag file?
Thx.
Small comment about 3, we prefer using ExternalProject_Add on Cmake on top of submodule.
