sdc icon indicating copy to clipboard operation
sdc copied to clipboard

automatic generation of type checks for overload

Open vlad-perevezentsev opened this issue 4 years ago • 2 comments

vlad-perevezentsev avatar Aug 17 '20 14:08 vlad-perevezentsev

Hello @vlad-perevezentsev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-09-29 14:36:35 UTC

pep8speaks avatar Aug 17 '20 14:08 pep8speaks

https://github.com/IntelPython/sdc/blob/numba_typing/numba_typing/local_variable_type_annotations.py#L11

This code actually modifies original function globals. This shouldn't happen, please fix.

AlexanderKalistratov avatar Sep 13 '20 00:09 AlexanderKalistratov