numba-dpex icon indicating copy to clipboard operation
numba-dpex copied to clipboard

Move examples outside of numba_dpex to root folder

Open PokhodenkoSA opened this issue 5 years ago • 4 comments

I am not sure that examples should be a part of the package. We could install if but it is mostly for developers (not users) and easiest way to work with examples is by cloning sources.

/CC @diptorupd @reazulhoque

PokhodenkoSA avatar Nov 24 '20 13:11 PokhodenkoSA

@mingjie-intel @oleksandr-pavlyk @chudur-budur What do you think of the proposal?

diptorupd avatar Oct 07 '22 05:10 diptorupd

@mingjie-intel @oleksandr-pavlyk @chudur-budur What do you think of the proposal?

I agree with moving out the examples from the numba_dpex folder.

chudur-budur avatar Oct 07 '22 18:10 chudur-budur

Usually projects move examples into a separate repo (easier to clone), e.g.

  • https://github.com/numba/numba-examples
  • https://github.com/pybind/python_example
  • https://github.com/scikit-build/scikit-build-sample-projects

Scikit-Learn stores examples in the repo, like suggested in this issue, see scikit-learn/scikit-learn/examples.

oleksandr-pavlyk avatar Oct 07 '22 20:10 oleksandr-pavlyk

@ZzEeKkAa can take a look. Moving the examples out of the package is straightforward. However, there are some test cases in numba_dpex/tests/debugging that depend on some of the examples. It was an unfortunate design decision and any files needed by a test case should be inside the tests directory.

diptorupd avatar May 03 '23 05:05 diptorupd