dpctl icon indicating copy to clipboard operation
dpctl copied to clipboard

Technical debt clean-up in test suite

Open ndgrigorian opened this issue 4 months ago • 10 comments

This PR proposes reducing the scope of the dpctl test suite by redacting tests which are redundant

For example, the dpctl test suite for element-wise functions repeatedly tests for things like usm_type of the output array. But the output array usm_type is determined in the function which dispatches to the element-wise kernel, and therefore, only needs to be tested once

  • [X] Have you provided a meaningful PR description?
  • [ ] Have you added a test, reproducer or referred to an issue with a reproducer?
  • [ ] Have you tested your changes locally for CPU and GPU devices?
  • [ ] Have you made sure that new changes do not introduce compiler warnings?
  • [ ] Have you checked performance impact of proposed changes?
  • [ ] Have you added documentation for your changes, if necessary?
  • [ ] Have you added your changes to the changelog?
  • [ ] If this PR is a work in progress, are you opening the PR as a draft?

ndgrigorian avatar Sep 10 '25 20:09 ndgrigorian

View rendered docs @ https://intelpython.github.io/dpctl/pulls/2144/index.html

github-actions[bot] avatar Sep 10 '25 20:09 github-actions[bot]

Coverage Status

coverage: 85.24% (-0.02%) from 85.262% when pulling d97f84053bd55b2446fcfb481cf8e6ffce98fb0b on reduce-bloat-in-dpctl-test-suite into 878cc1935c8a9fa514b355f5164539cdd8e1be39 on master.

coveralls avatar Sep 10 '25 20:09 coveralls

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_143 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Sep 10 '25 20:09 github-actions[bot]

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_144 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Sep 10 '25 22:09 github-actions[bot]

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_155 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Sep 16 '25 22:09 github-actions[bot]

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_155 ran successfully. Passed: 1114 Failed: 7 Skipped: 119

github-actions[bot] avatar Sep 16 '25 22:09 github-actions[bot]

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_160 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Sep 17 '25 20:09 github-actions[bot]

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_164 ran successfully. Passed: 1115 Failed: 6 Skipped: 119

github-actions[bot] avatar Sep 17 '25 21:09 github-actions[bot]

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_191 ran successfully. Passed: 1113 Failed: 8 Skipped: 119

github-actions[bot] avatar Sep 17 '25 23:09 github-actions[bot]

Changes in this PR reduce time of execution of test suite on my CPU from 6 minutes and 39 seconds to 5 minutes and 43 seconds.

Coverage drop of -0.02% is minimal and is likely a fluke.

sycloid avatar Sep 29 '25 18:09 sycloid