dpctl icon indicating copy to clipboard operation
dpctl copied to clipboard

Published 20 hours ago • verified publisher icon IntelPython

Custom implementation of isfinite

Open oleksandr-pavlyk opened this issue 1 year ago • 11 comments

This PR should address issues test failures from gh-1378

It works around very annoying SYCLOS bug introduced with pull down of clang 18.0

It adds a custom implementation of math_utils::isfinite to work around this failure.

  • [x] Have you provided a meaningful PR description?
  • [ ] Have you added a test, reproducer or referred to an issue with a reproducer?
  • [ ] Have you tested your changes locally for CPU and GPU devices?
  • [ ] Have you made sure that new changes do not introduce compiler warnings?
  • [ ] Have you checked performance impact of proposed changes?
  • [x] If this PR is a work in progress, are you opening the PR as a draft?

oleksandr-pavlyk avatar Aug 31 '23 21:08 oleksandr-pavlyk

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1383/index.html

github-actions[bot] avatar Aug 31 '23 22:08 github-actions[bot]

Coverage Status

coverage: 85.635%. remained the same when pulling dca06502a54b282f48575f937a398d94575bd0b6 on custom-is-finite into 9f98baf04db373ac45805ed91fe9339b62b8f40c on master.

coveralls avatar Aug 31 '23 22:08 coveralls

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_37 ran successfully. Passed: 916 Failed: 84 Skipped: 119

github-actions[bot] avatar Aug 31 '23 23:08 github-actions[bot]

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_38 ran successfully. Passed: 916 Failed: 84 Skipped: 119

github-actions[bot] avatar Sep 01 '23 02:09 github-actions[bot]

@ndgrigorian This PR has fixed SYCL-OS workflow.

oleksandr-pavlyk avatar Sep 01 '23 13:09 oleksandr-pavlyk

This PR should address issues test failures from gh-1378

Nit but I think you meant gh-1375 here.

ndgrigorian avatar Sep 01 '23 18:09 ndgrigorian

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_39 ran successfully. Passed: 916 Failed: 84 Skipped: 119

github-actions[bot] avatar Sep 02 '23 04:09 github-actions[bot]

Since the issue has been fixed in SYCLOS, perhaps this PR can wait.

oleksandr-pavlyk avatar Sep 06 '23 15:09 oleksandr-pavlyk

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_54 ran successfully. Passed: 916 Failed: 84 Skipped: 119

github-actions[bot] avatar Sep 06 '23 17:09 github-actions[bot]

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_54 ran successfully. Passed: 916 Failed: 84 Skipped: 119

github-actions[bot] avatar Sep 06 '23 17:09 github-actions[bot]

Array API standard conformance tests for dpctl=0.14.6dev5=py310ha25a700_4 ran successfully. Passed: 916 Failed: 84 Skipped: 119

github-actions[bot] avatar Sep 08 '23 15:09 github-actions[bot]

Closing as no longer relevant

oleksandr-pavlyk avatar May 21 '24 11:05 oleksandr-pavlyk