fastRAG icon indicating copy to clipboard operation
fastRAG copied to clipboard

Question for the replug_parallel_reader

Open szhang42 opened this issue 10 months ago • 1 comments

Hello,

Thanks for this fantastic repo! I have a question for the replug_parallel_reader.ipynb. I follow the same code and setting in replug_parallel_reader.ipynb. For the question ""Who is the main villan in Lord of the Rings?", my answer output is Roman Empire. This answer seems incorrect compared to the answer ("Sauron") shown in the above ipynb notebook.

If possible, could you please let me know what could be potential reasons for this? Thanks!

szhang42 avatar Apr 24 '24 04:04 szhang42

Hello @peteriz @danielfleischer! Also, I have another follow-up question: If I want to remove the replug part in the replug_parallel reader file, should I just comment out the invocation_layer as below? Thanks!

PrompterModel = PromptModel( model_name_or_path= "meta-llama/Llama-2-7b-chat-hf", use_gpu= True, # invocation_layer_class=ReplugHFLocalInvocationLayer, model_kwargs= dict( max_new_tokens=10, model_kwargs= dict( #device_map = "auto", torch_dtype = torch.bfloat16), generation_kwargs=dict(do_sample=True)))

szhang42 avatar Apr 26 '24 08:04 szhang42

We refactored the library to be compatible with Haystack v2; Generators replace the invocation layer concept. Please try it out and see if there are any issue.

danielfleischer avatar May 23 '24 08:05 danielfleischer