control-flag icon indicating copy to clipboard operation
control-flag copied to clipboard

Change github download url list filename

Open MatheMatrix opened this issue 3 years ago • 3 comments

The filename is far from the actual url list:

original name |  lines    | new name
----------------------------------------
c100.txt      |  6306     | c1000.txt
cpp100.txt    |  13915    | cpp10000.txt
java10.txt    |  73783    | java10000.txt

MatheMatrix avatar Nov 03 '21 05:11 MatheMatrix

Seems reasonable to me. Adding @nhasabni for his approval, too.

jgottschlich avatar Nov 03 '21 16:11 jgottschlich

Looks reasonable to me; approved. Waiting for @nhasabni to approve as well.

Thank you @MatheMatrix for your correction and contribution!

Justin

jgottschlich avatar Nov 03 '21 16:11 jgottschlich

hi @MatheMatrix,

Thanks for the PR. Suffix 100 in the name c100.txt is for the number of GitHub stars that were used to obtain the repositories for mining. So, IMO, name c1000.txt would be misleading. That being said, I think the description in README could be corrected. Would you be interested in correcting the description in README? Thanks.

nhasabni avatar Nov 03 '21 17:11 nhasabni