MART icon indicating copy to clipboard operation
MART copied to clipboard

Upgrade template 1.4.0->2.0.2

Open mzweilin opened this issue 1 year ago • 2 comments

What does this PR do?

Upgrade to the latest template 2.0.2 at https://github.com/ashleve/lightning-hydra-template

Changes

  • upgrade to hydra 1.3
  • upgrade toolkits in pre-commit
  • config datamodule -> data
  • add a cpu trainer config
  • move src.tasks to src
  • stop exporting extra log after a task exception.
  • split src.utils.utils into several .py files
  • add aim as a logger
  • update .gitignore for the aim logger

Already included (or with newer versions) in #192

  • torch ~= 1.13.1 -> torch ~= 2.0.1
  • pytorch-lightning ~= 1.6.5 -> lightning ~= 2.0.2
  • torchmetrics == 0.6.0 -> torchmetrics == 0.11.4 (newer PL requires torchmetrics>0.6.0)
  • use lightning.fabric for TPU

[Resolved] The PR depends on https://github.com/Lightning-AI/torchmetrics/issues/1024 We won't upgrade torchmetrics until they fix mAP.

Type of change

Please check all relevant options.

  • [ ] Improvement (non-breaking)
  • [ ] Bug fix (non-breaking)
  • [ ] New feature (non-breaking)
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • [x] pytest

Before submitting

  • [x] The title is self-explanatory and the description concisely explains the PR
  • [x] My PR does only one thing, instead of bundling different changes together
  • [x] I list all the breaking changes introduced by this pull request
  • [ ] I have commented my code
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

mzweilin avatar Jun 06 '23 00:06 mzweilin

I should note that it looks like torchmetrics 1.0 will be released soon and that will re-include the mAP implementation that uses cocoapi. See: https://github.com/Lightning-AI/torchmetrics/milestone/13

dxoigmn avatar Jun 22 '23 21:06 dxoigmn

torchmetrics 1.0 has been released! Upgrade all the dependencies!

dxoigmn avatar Jul 05 '23 20:07 dxoigmn