MediaSDK icon indicating copy to clipboard operation
MediaSDK copied to clipboard

Wrong buffer id in VPP GetVideoParams

Open davidlaporte2 opened this issue 4 years ago • 2 comments

At this line, https://github.com/Intel-Media-SDK/MediaSDK/blob/b3f65c2b5a147046ff82fcb4c0e721dff59daa1b/_studio/mfx_lib/vpp/src/mfx_vpp_hw.cpp#L1946

the buffer Id MFX_EXTBUFF_VPP_VIDEO_SIGNAL_INFO must be used to identify a mfxExtVPPVideoSignalInfo. (In the code, MFX_EXTBUFF_VIDEO_SIGNAL_INFO is wrongly used.)

davidlaporte2 avatar Oct 14 '21 12:10 davidlaporte2

This seems strange. Also note that all surrounding IDs are for the VPP.

Also MFX_EXTBUFF_VIDEO_SIGNAL_INFO does not match MFX_EXTBUFF_VPP_VIDEO_SIGNAL_INFO 's FOURCC so this is not just some implicit alias.

See: https://github.com/Intel-Media-SDK/MediaSDK/blob/master/doc/mediasdk-man.md#mfxextvppvideosignalinfo

https://github.com/Intel-Media-SDK/MediaSDK/blob/510d19dcace1d8c57567fdd40b557155ab11ab8e/api/include/mfxstructures.h#L915

https://github.com/Intel-Media-SDK/MediaSDK/blob/510d19dcace1d8c57567fdd40b557155ab11ab8e/api/include/mfxstructures.h#L929

MathieuGirard avatar Oct 14 '21 13:10 MathieuGirard

Thank you @MathieuGirard ! It's a bug. To be fixed

dmitryermilov avatar Oct 14 '21 20:10 dmitryermilov