Mark McDonnell

Results 240 comments of Mark McDonnell

Thanks @tedmielczarek-fastly I've created a ticket internally to investigate and track this request.

👋🏻 Hi @LevOlkha Can you provide (or some of) your Terraform configuration (i.e. your Fastly specific configuration such as your `logging_bigquery` block). It would be useful to know what your...

👋🏻 I'm going to close this issue as I've been informed that as of Sept 2022 (approx) this setting is no longer needed.

We can use something like the following code to fix this issue... ```go DefaultFunc: schema.EnvDefaultFunc("GOOGLE_PROJECT", ""), ``` or ```go DefaultFunc: schema.MultiEnvDefaultFunc([]string{ "GOOGLE_PROJECT", "GOOGLE_CLOUD_PROJECT", "GCLOUD_PROJECT", "CLOUDSDK_CORE_PROJECT", }, "") ```

👋🏻 @a-suenami there is a new Hashicorp plugin framework (incompatible with their v2 SDK that the Fastly provider uses) and in the new framework HashiCorp recommend moving away from nested...

**UPDATE:** The new HashiCorp framework's `map` nested attribute type does indeed help with diff clarity. See https://github.com/Integralist/terraform-provider-fastly-framework/pull/7 for details.

Hi @glerchundi > I submitted a new PR to https://github.com/fastly/go-fastly/pull/384 that would unlock the possibility to further continue with this proposal. Great! 🙂 I'll aim to take a look at...

👋🏻 @glerchundi apologies for the delay but I've had other priorities since we last spoke and this has been my first opportunity to revisit this issue. I just wanted to...

I've done further testing and have marked my PR ready for review: https://github.com/fastly/terraform-provider-fastly/pull/661 Please take a look and let me know your thoughts and if this is meeting your needs....

Specifically, see my comment as to why we need the `content` attribute to be a base64 encoded string: https://github.com/fastly/terraform-provider-fastly/pull/661#pullrequestreview-1339970356