instrumental_agent-ruby icon indicating copy to clipboard operation
instrumental_agent-ruby copied to clipboard

Published 20 hours ago • verified publisher icon Instrumental

Release 3.0.0

Open mediocretes opened this issue 5 years ago • 4 comments

mediocretes avatar Aug 22 '19 21:08 mediocretes

I think probably https://github.com/Instrumental/instrumental_agent-ruby/blob/master/lib/instrumental/agent.rb#L350-L356 needs to set failures to 0 if we have success in the read block, unless you intended the fix to be count failures since agent start?

janxious avatar Aug 23 '19 18:08 janxious

Totally reasonable. As it is now, it will count up until something forces run_worker_loop to exit, and then it will be reset on the next run, which is fine for the SSL problem we're working on now, but probably not ideal for softer failure modes.

mediocretes avatar Aug 23 '19 18:08 mediocretes

I assume https://github.com/Instrumental/instrumental_agent-ruby/pull/66/commits/bd443c0e44b6f0b9b159058564438f5800b20e37 is what we've been using in prod for the last week-ish?

janxious avatar Sep 03 '19 16:09 janxious

Yes, prod is on 3.0.0.alpha, and looks good so far.

mediocretes avatar Sep 03 '19 18:09 mediocretes