IGListKit icon indicating copy to clipboard operation
IGListKit copied to clipboard

Fix unsigned integer overflow

Open tuoxie007 opened this issue 6 years ago • 9 comments

Changes in this pull request

Issue fixed: #

Checklist

  • [x] All tests pass. Demo project builds and runs.
  • [ ] I added tests, an experiment, or detailed why my change isn't tested.
  • [x] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • [x] I have reviewed the contributing guide

tuoxie007 avatar Jan 24 '19 03:01 tuoxie007

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jan 24 '19 03:01 facebook-github-bot

1 Warning
:warning: All pull requests should have a milestone attached, unless marked #trivial.

Generated by :no_entry_sign: Danger

iglistkit-bot avatar Jan 24 '19 03:01 iglistkit-bot

ummm @tuoxie007 r u still merging this PR? thanks

lorixx avatar Jun 19 '19 04:06 lorixx

@tuoxie007 can you sign the CLA? thanks

lorixx avatar Jun 24 '19 05:06 lorixx

@tuoxie007 can you sign the CLA? thanks

lorixx avatar Nov 25 '19 15:11 lorixx

@tuoxie007 can you sign the CLA? thanks

Sorry for late, done for cla.

tuoxie007 avatar Nov 26 '19 01:11 tuoxie007

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Nov 26 '19 01:11 facebook-github-bot

Thank you @tuoxie007 Jason, can you rebase and update the PR w/ the latest master? thx

lorixx avatar Nov 26 '19 02:11 lorixx

@tuoxie007 has updated the pull request. Re-import the pull request

facebook-github-bot avatar Nov 26 '19 08:11 facebook-github-bot

@tuoxie007 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar May 02 '23 06:05 facebook-github-bot

@TimOliver merged this pull request in Instagram/IGListKit@164f39c4d4a1158c0e1514dab77f42b353b5c49a.

facebook-github-bot avatar May 02 '23 09:05 facebook-github-bot